Add Coverage Reporting for Gremlin JS #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L0Lmaker
force-pushed
the
rithin/an-1208-gremlin-js-coverage
branch
from
b20deda to
135a30a
Compare
xiazcy
reviewed
Aug 22, 2022
| "TODO": "# test other mime types like graphbinary stringd", | ||
| "features": "npm run features-graphson30 && npm run features-graphbinary", | ||
| "features-graphson30": "cross-env CLIENT_MIMETYPE='application/vnd.gremlin-v3.0+json' cucumber-js --require test/cucumber ../../../../../gremlin-test/features/", | ||
| "features-graphbinary": "cross-env CLIENT_MIMETYPE='application/vnd.graphbinary-v1.0' cucumber-js --require test/cucumber ../../../../../gremlin-test/features/", | ||
| "features-docker": "npm run features-graphson30-docker && npm run features-graphbinary-docker", |
There was a problem hiding this comment.
Aren't these the commands for running this in Docker?
There was a problem hiding this comment.
oops, these are unnecessary, will remove them
Codecov Report
@@ Coverage Diff @@
## 3.5-dev #24 +/- ##
===========================================
+ Coverage 63.58% 71.45% +7.86%
===========================================
Files 23 81 +58
Lines 3636 6656 +3020
===========================================
+ Hits 2312 4756 +2444
- Misses 1145 1721 +576
Partials 179 179
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xiazcy
reviewed
Aug 23, 2022
| @@ -4,6 +4,16 @@ | |||
| "lockfileVersion": 1, | |||
| "requires": true, | |||
| "dependencies": { | |||
| "@ampproject/remapping": { | |||
There was a problem hiding this comment.
Wondering why the package-lock file is adding a large chunk of code again, is it the node version?
There was a problem hiding this comment.
installed with same node and npm version, the changes refer to the dependencies and sub-dependencies of the nyc dependency that is added in this PR
There was a problem hiding this comment.
added 100 dependencies, but it's ok for node world %)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.